steveloughran commented on a change in pull request #1106: HADOOP-16380. S3A
non-recursive deletion of root to return false
URL: https://github.com/apache/hadoop/pull/1106#discussion_r304124133
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -2193,6 +2193,13 @@ void removeKeys(
*/
@Retries.RetryTranslated
public boolean delete(Path f, boolean recursive) throws IOException {
+ if (f.isRoot()) {
Review comment:
this should go after the entrypoint, so that the metrics are incremented and
FS open/closed state are checked
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
