adoroszlai commented on a change in pull request #1076: HDDS-1782. Add an option to MiniOzoneChaosCluster to read files multiple times. Contributed by Mukul Kumar Singh. URL: https://github.com/apache/hadoop/pull/1076#discussion_r304247671
########## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/chaos/TestProbability.java ########## @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.chaos; + +import org.apache.commons.lang3.RandomUtils; + +/** + * Class to keep track of test probability. + */ +public class TestProbability { + private int pct; + + private TestProbability(int pct) { + this.pct = pct; + } + + public boolean isTrue() { + return (RandomUtils.nextInt() * pct / 100) == 1; Review comment: @arp7 @mukul1987 Yes, the new `isTrue` logic is fine. (I would add a special case for 0 to avoid division by zero, and check for negative values in the constructor, but these are not "normal" use cases I guess.) But I didn't want to +1 the whole change, since I'm not familiar with most of it... (and my +1 is not-binding anyway). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
