steveloughran commented on issue #974: HDFS-9913. DistCp to add -useTrash to move deleted files to Trash URL: https://github.com/apache/hadoop/pull/974#issuecomment-512229430 OK, cause is that the test setup calls `assertDeleted()` to clean up the trash dir, and the CTU check there actually fails if the file doesn't exist before the delete. Which is actually something we should question. For now: reverted this PR so everything will be working before the US wakes up. I know it's a quick fix but I'd be depending on others to review, etc, etc and the failing test will be around for 24h minimum. @asagjj : Can you submit an updated PR with the delete setup something like: ```java Path trashRootDir = remoteFS.getTrashRoot(null); remoteFS.delete(trashRootDir, true); ContractTestUtils.assertPathDoesNotExist(remoteFS, "trash", trashRootDir ) ``` We don't need to worry about the before state or the return value of delete, just that the dir isn't there. Thanks
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
