adoroszlai opened a new pull request #1120: HDDS-1822. NPE in SCMCommonPolicy.chooseDatanodes URL: https://github.com/apache/hadoop/pull/1120 ## What changes were proposed in this pull request? NPE is caused by base `chooseDatanodes` not checking for `excludedNodes` being `null`. Default placement policy is now random (HDDS-1801), but `TestContainerPlacementFactory#testDefaultPolicy` still reflects rack-aware policy. Adding the `null` check makes the test fail instead of erroring out with NPE. Changed the test to only check default policy being returned, not its behavior (since that should be verified in the specific policy's unit test). https://issues.apache.org/jira/browse/HDDS-1822 ## How was this patch tested? Unit test.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
