hanishakoneru commented on a change in pull request #948: HDDS-1649. On
installSnapshot notification from OM leader, download checkpoint and reload OM
state
URL: https://github.com/apache/hadoop/pull/948#discussion_r305032543
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java
##########
@@ -159,15 +159,18 @@ public void decNumKeys() {
}
public void setNumVolumes(long val) {
- this.numVolumes.incr(val);
+ long oldVal = this.numVolumes.value();
+ this.numVolumes.incr(val - oldVal);
Review comment:
The setNumVolumes is called with the total number of rows in VolumeTable.
This is not the difference between the old value and new value.
metrics.setNumVolumes(metadataManager.countRowsInTable(metadataManager
.getVolumeTable()));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
