hadoop-yetus commented on issue #299: Support Log4j 2 and Logback URL: https://github.com/apache/hadoop/pull/299#issuecomment-513334665 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 73 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 24 | Maven dependency ordering for branch | | +1 | mvninstall | 1189 | trunk passed | | +1 | compile | 1095 | trunk passed | | +1 | checkstyle | 163 | trunk passed | | +1 | mvnsite | 108 | trunk passed | | +1 | shadedclient | 1077 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 89 | trunk passed | | 0 | spotbugs | 135 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 24 | branch/hadoop-project no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 27 | Maven dependency ordering for patch | | +1 | mvninstall | 75 | the patch passed | | -1 | compile | 126 | root in the patch failed. | | -1 | javac | 126 | root in the patch failed. | | -0 | checkstyle | 141 | root: The patch generated 62 new + 26 unchanged - 1 fixed = 88 total (was 27) | | +1 | mvnsite | 91 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 3 | The patch has no ill-formed XML file. | | -1 | shadedclient | 151 | patch has errors when building and testing our client artifacts. | | +1 | javadoc | 68 | the patch passed | | 0 | findbugs | 13 | hadoop-project has no data from findbugs | | -1 | findbugs | 144 | hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 12 | hadoop-project in the patch passed. | | -1 | unit | 577 | hadoop-common in the patch failed. | | +1 | asflicense | 28 | The patch does not generate ASF License warnings. | | | | 5381 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-common-project/hadoop-common | | | Switch statement found in org.apache.hadoop.log.metrics.Log4j2EventCounter.append(LogEvent) where default case is missing At Log4j2EventCounter.java:where default case is missing At Log4j2EventCounter.java:[lines 40-51] | | Failed junit tests | hadoop.net.TestNetUtils | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-299/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/299 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle | | uname | Linux 22162bef78fd 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 7f1b76c | | Default Java | 1.8.0_212 | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-299/1/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-299/1/artifact/out/patch-compile-root.txt | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-299/1/artifact/out/diff-checkstyle-root.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-299/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-299/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-299/1/testReport/ | | Max. process+thread count | 1340 (vs. ulimit of 5500) | | modules | C: hadoop-project hadoop-common-project/hadoop-common U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-299/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
