[ 
https://issues.apache.org/jira/browse/HADOOP-16398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891224#comment-16891224
 ] 

Anu Engineer edited comment on HADOOP-16398 at 7/23/19 5:24 PM:
----------------------------------------------------------------

just wondering if we should do this change instead of the todo comment?
{code:java}
// If hadoop prometheus endpoint is enabled, then HDDS/Ozone
// will reuse the same end point.
if(conf.getBoolean("hadoop.prometheus.endpoint.enabled")) {
  conf.setBoolean("hdds.prometheus.endpoint.enabled", false);
}{code}
The assumption here is that baseHTTPServer when used by HDDS and Ozone will 
actually be an OzoneConfiguration and it will allow us to set the hdds config 
value. If not, in the pure Hadoop case, it will be a no-op, yes; the config 
space will have an extra entry but not used by anyone. However, that entry will 
be visible in the /config servelet. 

 

 


was (Author: anu):
just wondering if we should do this change instead of the todo comment?
{code:java}
// If hadoop prometheus endpoint is enabled, then HDDS/Ozone
// will reuse the same end point.
if(conf.getBoolean("hadoop.prometheus.endpoint.enabled")) {
  conf.setBoolean("hdds.prometheus.endpoint.enabled", false);
}{code}

> Exports Hadoop metrics to Prometheus
> ------------------------------------
>
>                 Key: HADOOP-16398
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16398
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: metrics
>            Reporter: Akira Ajisaka
>            Assignee: Akira Ajisaka
>            Priority: Major
>         Attachments: HADOOP-16398.001.patch, HADOOP-16398.002.patch
>
>
> Hadoop common side of HDDS-846. HDDS already have its own 
> PrometheusMetricsSink, so we can reuse the implementation.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to