arp7 commented on a change in pull request #1148: HDDS-1848. Fix 
TestOzoneManagerHA and TestOzoneManagerSnapShotProvider.
URL: https://github.com/apache/hadoop/pull/1148#discussion_r306605526
 
 

 ##########
 File path: 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneHAClusterImpl.java
 ##########
 @@ -169,6 +169,11 @@ public MiniOzoneCluster build() throws IOException {
         throw new IllegalArgumentException("Number of active OMs cannot be " +
             "more than the total number of OMs");
       }
+
+      // If num of ActiveOMs is not set, set it to numOfOMs.
 
 Review comment:
   Should this be set before the check on line 168?
   
   Also why not set it always. Would that be wrong?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to