bharatviswa504 commented on a change in pull request #1148: HDDS-1848. Fix
TestOzoneManagerHA and TestOzoneManagerSnapShotProvider.
URL: https://github.com/apache/hadoop/pull/1148#discussion_r306608490
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneHAClusterImpl.java
##########
@@ -169,6 +169,11 @@ public MiniOzoneCluster build() throws IOException {
throw new IllegalArgumentException("Number of active OMs cannot be " +
"more than the total number of OMs");
}
+
+ // If num of ActiveOMs is not set, set it to numOfOMs.
Review comment:
If numOfActiveOMs is not set we set, then only we should set numOfActiveOMs
with numofOMs (which is total count of OMS). When user set some value to
numOfActiveOMs we don't want to override that, this is the reason for doing
that.
If it is not set, we don't need to do this check
if (numOfActiveOMs > numOfOMs) {
throw new IllegalArgumentException("Number of active OMs cannot be "
+
"more than the total number of OMs");
}
So, it is okay to add after this too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
