bgaborg commented on a change in pull request #1134: HADOOP-16433. S3Guard:
Filter expired entries and tombstones when lis…
URL: https://github.com/apache/hadoop/pull/1134#discussion_r306683097
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/PathMetadata.java
##########
@@ -71,6 +78,7 @@ public PathMetadata(S3AFileStatus fileStatus, Tristate
isEmptyDir, boolean
this.fileStatus = fileStatus;
this.isEmptyDirectory = isEmptyDir;
this.isDeleted = isDeleted;
+ this.setLastUpdated(lastUpdated);
Review comment:
I'd prefer `Preconditions.checkArgument(lastUpdated >=0 ` instead. It's
better fail fast if there's a negative value, we don't need to be that
failproof here imo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
