bharatviswa504 commented on a change in pull request #1150: HDDS-1816:
ContainerStateMachine should limit number of pending apply transactions
URL: https://github.com/apache/hadoop/pull/1150#discussion_r306971240
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -175,6 +179,10 @@ public ContainerStateMachine(RaftGroupId gid,
ContainerDispatcher dispatcher,
final int numContainerOpExecutors = conf.getInt(
OzoneConfigKeys.DFS_CONTAINER_RATIS_NUM_CONTAINER_OP_EXECUTORS_KEY,
OzoneConfigKeys.DFS_CONTAINER_RATIS_NUM_CONTAINER_OP_EXECUTORS_DEFAULT);
+ int maxPendingApplyTransactions = conf.getInt(
+
ScmConfigKeys.DFS_CONTAINER_RATIS_STATEMACHINE_MAX_PENDING_APPLY_TRANSACTIONS,
+
ScmConfigKeys.DFS_CONTAINER_RATIS_STATEMACHINE_MAX_PENDING_APPLY_TRANSACTIONS_DEFAULT);
+ applyTransactionSemaphore = new Semaphore(maxPendingApplyTransactions);
Review comment:
Question: Here do we need fair setting, to follow the order?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
