hadoop-yetus commented on issue #402: MAPREDUCE-7121. add Abortable so that we can abort output URL: https://github.com/apache/hadoop/pull/402#issuecomment-515555208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 22 | Maven dependency ordering for branch | | +1 | mvninstall | 1033 | trunk passed | | +1 | compile | 1013 | trunk passed | | +1 | checkstyle | 153 | trunk passed | | +1 | mvnsite | 128 | trunk passed | | +1 | shadedclient | 956 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 91 | trunk passed | | 0 | spotbugs | 76 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 190 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 23 | Maven dependency ordering for patch | | +1 | mvninstall | 77 | the patch passed | | +1 | compile | 968 | the patch passed | | -1 | javac | 968 | root generated 1 new + 1476 unchanged - 0 fixed = 1477 total (was 1476) | | -0 | checkstyle | 146 | root: The patch generated 10 new + 854 unchanged - 2 fixed = 864 total (was 856) | | +1 | mvnsite | 113 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 669 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 95 | the patch passed | | -1 | findbugs | 127 | hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | -1 | findbugs | 90 | hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 532 | hadoop-common in the patch passed. | | +1 | unit | 335 | hadoop-mapreduce-client-core in the patch passed. | | -1 | asflicense | 48 | The patch generated 2 ASF License warnings. | | | | 6835 | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-common-project/hadoop-common | | | instanceof will always return true for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:for all non-null values in org.apache.hadoop.io.SequenceFile$Writer.abort(), since all org.apache.hadoop.fs.FSDataOutputStream are instances of org.apache.hadoop.fs.common.Abortable At SequenceFile.java:[line 881] | | FindBugs | module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core | | | instanceof will always return false in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:in org.apache.hadoop.mapred.ReduceTask.runOldReducer(JobConf, TaskUmbilicalProtocol, Task$TaskReporter, RawKeyValueIterator, RawComparator, Class, Class), since a org.apache.hadoop.mapred.ReduceTask$OldTrackingRecordWriter<OUTKEY,OUTVALUE> can't be a org.apache.hadoop.fs.common.Abortable At ReduceTask.java:[line 461] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/402 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 264b7516c146 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / c7c7a88 | | Default Java | 1.8.0_212 | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/diff-compile-javac-root.txt | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/diff-checkstyle-root.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/testReport/ | | asflicense | https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 1645 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-402/2/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
