aajisaka commented on a change in pull request #1170: HADOOP-16398. Exports
Hadoop metrics to Prometheus
URL: https://github.com/apache/hadoop/pull/1170#discussion_r308955056
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/BaseHttpServer.java
##########
@@ -70,6 +70,12 @@ public BaseHttpServer(Configuration conf, String name)
throws IOException {
this.httpAddress = getHttpBindAddress();
this.httpsAddress = getHttpsBindAddress();
HttpServer2.Builder builder = null;
+
+ // Avoid registering o.a.h.http.PrometheusServlet in HttpServer2.
+ // TODO: Replace "hadoop.prometheus.endpoint.enabled" with
+ // CommonConfigurationKeysPublic.HADOOP_PROMETHEUS_ENABLED when possible.
+ conf.setBoolean("hadoop.prometheus.endpoint.enabled", false);
+
Review comment:
Thanks. I think your understanding is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
