bharatviswa504 commented on a change in pull request #1174: HDDS-1856. Make
required changes for Non-HA to use new HA code in OM.
URL: https://github.com/apache/hadoop/pull/1174#discussion_r308989717
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
##########
@@ -248,10 +291,20 @@ public long getFlushIterations() {
* @param response
* @param transactionIndex
*/
- public synchronized void add(OMClientResponse response,
+ public synchronized CompletableFuture<Void> add(OMClientResponse response,
Review comment:
This is for a temporary thing. Sooner, all OM uses HA, so this code will be
removed in later point of time. And in HA case, we don't even use future. So, I
think this should be okay, let me know you still want to use Optional here?
So, in code if you see where future will be used, we don't need != null
check.
https://github.com/apache/hadoop/pull/1166/files in
OzoneManagerProtocolServerSideTranslatorPB.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
