bshashikant commented on a change in pull request #1113: HDDS-1798. Propagate
failure in writeStateMachineData to Ratis. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1113#discussion_r310070528
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestContainerStateMachineFailures.java
##########
@@ -170,27 +173,19 @@ public void testContainerStateMachineFailures() throws
Exception {
HddsDispatcher dispatcher = (HddsDispatcher)
ozoneContainer.getDispatcher();
Assert.assertTrue(dispatcher.getMissingContainerSet().isEmpty());
- // restart the hdds datanode and see if the container is listed in the
- // in the missing container set and not in the regular set
+ // restart the hdds datanode, container should not in the regular set
cluster.restartHddsDatanode(0, true);
ozoneContainer = cluster.getHddsDatanodes().get(0)
.getDatanodeStateMachine().getContainer();
- dispatcher = (HddsDispatcher) ozoneContainer.getDispatcher();
-
Assert
.assertNull(ozoneContainer.getContainerSet().getContainer(containerID));
- Assert.assertTrue(dispatcher.getMissingContainerSet()
- .contains(containerID));
- ContainerProtos.ContainerCommandRequestProto.Builder request =
- ContainerProtos.ContainerCommandRequestProto.newBuilder();
- request.setCmdType(ContainerProtos.Type.CreateContainer);
- request.setContainerID(containerID);
- request.setCreateContainer(
- ContainerProtos.CreateContainerRequestProto.getDefaultInstance());
- request.setDatanodeUuid(
-
cluster.getHddsDatanodes().get(0).getDatanodeDetails().getUuidString());
- Assert.assertEquals(ContainerProtos.Result.CONTAINER_MISSING,
- dispatcher.dispatch(request.build(), null).getResult());
+
+ OzoneKeyDetails keyDetails = objectStore.getVolume(volumeName)
+ .getBucket(bucketName).getKey("ratis");
+ Assert.assertTrue("Data length stored in the key does not match writes.",
+ keyDetails.getDataSize() == written);
Review comment:
Please add some comments stating why the keyLocationSize will show up as 2
as data will be written across 2 blocks in 2 different containers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
