bharatviswa504 commented on a change in pull request #1221: HDDS-1488. Scm cli
command to start/stop replication manager.
URL: https://github.com/apache/hadoop/pull/1221#discussion_r310406231
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
##########
@@ -154,6 +151,9 @@ public synchronized void start() {
if (!running) {
Review comment:
Here we need to check isRunning() method.
Take an example:
call start, stop, (but it has not stopped completely, calling start
immediately we try to start again if we only check running flag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
