Apache9 commented on a change in pull request #1222: HADOOP-16488 Deprecated
JsonSerialization and move it out of hadoop-c…
URL: https://github.com/apache/hadoop/pull/1222#discussion_r310416038
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##########
@@ -3718,52 +3709,42 @@ public static void dumpConfiguration(Configuration
config,
*/
public static void dumpConfiguration(Configuration config,
Writer out) throws IOException {
- JsonFactory dumpFactory = new JsonFactory();
- JsonGenerator dumpGenerator = dumpFactory.createGenerator(out);
- dumpGenerator.writeStartObject();
- dumpGenerator.writeFieldName("properties");
- dumpGenerator.writeStartArray();
- dumpGenerator.flush();
+ JsonWriter jsonWriter = new JsonWriter(out);
+ jsonWriter.beginObject().name("properties").beginArray().flush();
Review comment:
We have, but as you said below, if we purge jackson completely, there is no
way to ensure that the json format is not changed, as in tests we also use
gson...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
