steveloughran commented on issue #1207: Hadoop 16479 URL: https://github.com/apache/hadoop/pull/1207#issuecomment-518239493 regarding the current patch, production code looks OK, some minor changes suggested to the tests, primarily to satisfy my requirement "an assertion failure in a jenkins build to be informative enough to explain what is wrong". AssertTrue/false without any specifics never qualify there But: that test is verifying that created files against the test zone are readable —will it verify that the problem seen in the JIRA -user in a different TZ gets a different time? Some unit tests which just try to parse the strings should be able to do that, without needing to go near the object store
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
