ctubbsii commented on a change in pull request #1243: HADOOP-16494. Add SHA-512
checksum to release artifact to comply with the release distribution policy
URL: https://github.com/apache/hadoop/pull/1243#discussion_r311375764
##########
File path: dev-support/bin/create-release
##########
@@ -641,7 +641,7 @@ function signartifacts
for i in ${ARTIFACTS_DIR}/*; do
${GPG} --use-agent --armor --output "${i}.asc" --detach-sig "${i}"
- ${GPG} --print-mds "${i}" > "${i}.mds"
+ shasum -a 512 "${i}" > "${i}.sha512"
Review comment:
If you add `--tag` to this command, the file format is a bit more
self-descriptive. The `--tag` option uses BSD-style checksum, rather than GNU
coreutils style, which includes the algorithm name in the file contents
explicitly. It also avoids the confusing two space/space-star (text vs. binary
comparisons) delimiter of GNU style by always doing binary comparisons.
```suggestion
shasum -a 512 --tag "${i}" > "${i}.sha512"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
