xiaoyuyao commented on a change in pull request #1202: HDDS-1884. Support
Bucket ACL operations for OM HA.
URL: https://github.com/apache/hadoop/pull/1202#discussion_r311373795
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java
##########
@@ -124,6 +128,95 @@ public String getBucketName() {
return acls;
}
+ /**
+ * Add an ozoneAcl to list of existing Acl set.
+ * @param ozoneAcl
+ * @return true - if successfully added, false if not added or acl is
+ * already existing in the acl list.
+ */
+ public boolean addAcl(OzoneAcl ozoneAcl) {
Review comment:
Can we abstract these add/remove logic into common AclUtil class as we can
see similar logic in both bucket manager and key manager? For example,
public static boolean addAcl(List<OzoneAcls> existingAcls, OzoneAcl newAcl)
public static boolean removeAcl(List<OzoneAcls> existingAcls, OzoneAcl
newAcl)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
