vivekratnavel commented on a change in pull request #1146: HDDS-1366. Add
ability in Recon to track the number of small files in an Ozone Cluster
URL: https://github.com/apache/hadoop/pull/1146#discussion_r311799843
##########
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/FileSizeCountTask.java
##########
@@ -78,7 +78,8 @@ protected long getMaxFileSizeUpperBound() {
protected int getMaxBinSize() {
if (maxBinSize == -1) {
// extra bin to add files > 1PB.
- maxBinSize = calculateBinIndex(maxFileSizeUpperBound) + 1;
+ // 1 KB (2 ^ 10) is the smallest tracked file.
+ maxBinSize = nextClosetPowerIndexOfTwo(maxFileSizeUpperBound) - 10 + 1;
Review comment:
nit: typo in `nextClosestPowerIndexOfTwo`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
