jojochuang commented on a change in pull request #1223: HADOOP-16112. Delete
the baseTrashPath's subDir leads to don't modify baseTrashPath
URL: https://github.com/apache/hadoop/pull/1223#discussion_r311849544
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestTrash.java
##########
@@ -627,6 +630,34 @@ public void testExistingFileTrash() throws IOException {
e.getLocalizedMessage());
}
assertTrue(val2 == 0);
+
+ // Third rm a file which parent path is the same as above.
+ // Make baseTrashPath, at the same time delete existTrashPath
+ mkdir(fs, myFile);
+ writeFile(fs, new Path(myFile, "mySubFile2"), 10);
+ String[] args3 = new String[2];
+ args3[0] = "-rm";
+ args3[1] = new Path(myFile, "mySubFile2").toString();
+ int val3 = -1;
+ new Thread(new Runnable() {
+ @Override
+ public void run() {
+ try {
+ Thread.sleep(2000);
Review comment:
Better not to use sleep time to control thread order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
