pbacsko commented on a change in pull request #1261: YARN-9676. Add DEBUG and
TRACE level messages to AppLogAggregatorImpl…
URL: https://github.com/apache/hadoop/pull/1261#discussion_r312708272
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java
##########
@@ -386,6 +395,13 @@ private void uploadLogsForContainers(boolean appFinished)
if (logAggregationSucceedInThisCycle && deletionTask != null) {
delService.delete(deletionTask);
}
+ if (!diagnosticMessage.isEmpty()) {
+ LOG.debug("Sending log aggregation report along with the " +
+ "following diagnostic message:\"{}\"", diagnosticMessage);
+ }
+ if (!logAggregationSucceedInThisCycle) {
+ LOG.info("Log aggregation did not succeed in this cycle");
Review comment:
shouldn't this be a WARN or ERROR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
