adamantal commented on a change in pull request #1261: YARN-9676. Add DEBUG and TRACE level messages to AppLogAggregatorImpl… URL: https://github.com/apache/hadoop/pull/1261#discussion_r312826617
########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java ########## @@ -386,6 +395,13 @@ private void uploadLogsForContainers(boolean appFinished) if (logAggregationSucceedInThisCycle && deletionTask != null) { delService.delete(deletionTask); } + if (!diagnosticMessage.isEmpty()) { + LOG.debug("Sending log aggregation report along with the " + + "following diagnostic message:\"{}\"", diagnosticMessage); + } + if (!logAggregationSucceedInThisCycle) { + LOG.info("Log aggregation did not succeed in this cycle"); Review comment: Agreed. Modified accordingly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org