bgaborg commented on a change in pull request #1229: HADOOP-16490. Improve
S3Guard handling of FNFEs in copy
URL: https://github.com/apache/hadoop/pull/1229#discussion_r313424521
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java
##########
@@ -80,13 +82,18 @@
@SuppressWarnings("visibilitymodifier") // I want a struct of finals, for
real.
public class S3ARetryPolicy implements RetryPolicy {
+ private static final Logger LOG = LoggerFactory.getLogger(
+ S3ARetryPolicy.class);
+
+ private final Configuration configuration;
+
/** Final retry policy we end up with. */
private final RetryPolicy retryPolicy;
// Retry policies for mapping exceptions to
/** Base policy from configuration. */
- protected final RetryPolicy fixedRetries;
+ protected final RetryPolicy defaultRetries;
Review comment:
maybe exponentialBackoffRetry would be a better name for this, or do you
plan to make the retry implementation pluggable here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
