sodonnel commented on a change in pull request #1028: HDFS-14617 - Improve 
fsimage load time by writing sub-sections to the fsimage index
URL: https://github.com/apache/hadoop/pull/1028#discussion_r313806054
 
 

 ##########
 File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormatProtobuf.java
 ##########
 @@ -294,6 +368,19 @@ public int compare(FileSummary.Section s1, 
FileSummary.Section s2) {
        * a particular step to be started for once.
        */
       Step currentStep = null;
+      boolean loadInParallel =
+          conf.getBoolean(DFSConfigKeys.DFS_IMAGE_PARALLEL_LOAD_KEY,
+              DFSConfigKeys.DFS_IMAGE_PARALLEL_LOAD_DEFAULT);
+      // TODO - check for compression and if enabled disable parallel
+
+      ExecutorService executorService = null;
+      ArrayList<FileSummary.Section> subSections =
+          getAndRemoveSubSections(sections);
+      if (loadInParallel) {
+        executorService = Executors.newFixedThreadPool(
+            conf.getInt(DFSConfigKeys.DFS_IMAGE_PARALLEL_THREADS_KEY,
+                DFSConfigKeys.DFS_IMAGE_PARALLEL_THREADS_DEFAULT));
 
 Review comment:
   I added a log message here, and validated the thread count setting is not 
less than 1, otherwise I reset it to the default (4). I also pulled the code to 
do this check and to create the executor into a private method to reduce the 
noise in the already too long loadInternal method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to