[
https://issues.apache.org/jira/browse/HADOOP-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907568#comment-16907568
]
Erik Krogen commented on HADOOP-16391:
--------------------------------------
Hi [~BilwaST], thanks for continuing to work on this :) The checkstlye and
whitespace issues seem legitimate.
Besides those, I had one thought regarding the changes to {{MutableRate}}. The
new constructor basically makes it no longer a {{MutableRate}}, just a
{{MutableStat}} – the only difference between the two is that {{MutableRate}}
enforces the "Ops"/"Time" names and this constructor removes that convention.
Instead, would it make more sense to leave {{MutableRate}} unchanged and then
do this:
{code:java|title=MutableRatesWithAggregation}
metric = new MutableRate(name + typePrefix, name + typePrefix, false);
{code}
The output will look basically the same, with names like
"GetLongDeferredNumOps" instead of "GetLongNumDeferredOps", and seems a change
more in line with the intent of {{MutableRate}}. What do you think?
Also, the new test looks great, but can we also add an assertion that there is
a call for the deferred method name as well? You also have a typo: "Deferrred"
(three r's)
> Duplicate values in rpcDetailedMetrics
> --------------------------------------
>
> Key: HADOOP-16391
> URL: https://issues.apache.org/jira/browse/HADOOP-16391
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bilwa S T
> Assignee: Bilwa S T
> Priority: Major
> Attachments: HADOOP-16391-001.patch, HADOOP-16391-002.patch,
> image-2019-06-25-20-30-15-395.png, screenshot-1.png, screenshot-2.png
>
>
> In RpcDetailedMetrics init is called two times . Once for deferredRpcrates
> and other one rates metrics which causes duplicate values in RM and NM
> metrics.
> !image-2019-06-25-20-30-15-395.png!
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
