avijayanhwx commented on a change in pull request #1259: HDDS-1105 : Add
mechanism in Recon to obtain DB snapshot 'delta' updates from Ozone Manager
URL: https://github.com/apache/hadoop/pull/1259#discussion_r314932586
##########
File path:
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/ReconUtils.java
##########
@@ -90,7 +90,7 @@ public static File getReconDbDir(Configuration conf, String
dirConfigKey) {
* @param destPath destination path to untar to.
* @throws IOException ioException
*/
- public static void untarCheckpointFile(File tarFile, Path destPath)
+ public void untarCheckpointFile(File tarFile, Path destPath)
Review comment:
Yes I agree. But we decided to make the ReconUtils non static so that we can
inject a mock instance of it and unit test cleanly, removing the need for
Powermocks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
