xiaoyuyao commented on a change in pull request #1263: HDDS-1927. Consolidate
add/remove Acl into OzoneAclUtil class. Contri…
URL: https://github.com/apache/hadoop/pull/1263#discussion_r315466190
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
##########
@@ -235,123 +231,22 @@ public FileEncryptionInfo getFileEncryptionInfo() {
return encInfo;
}
- public List<OzoneAclInfo> getAcls() {
+ public List<OzoneAcl> getAcls() {
Review comment:
1st conversion is for RPC based request.
2nd conversion is for persistence to DB.
In between, we use OzoneAcl to manipulate the ACL. I understand we could
save the conversion by using the protobuf class directly. Here are reasons I
choose to keep Java class instead:
1. Raw protobuf class can't be extended easily for acl operations. We will
have to to wrap the acl operations anyway.
2. Given the scatter logic of ACL ops for volume/bucket/key/prefix, I would
prefer to have a unified code base that can be maintained/tested easily in the
long run.
3. ACL write operations are far less than ACL read. I would not expect this
to have big impact to ozone perf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
