xiaoyuyao commented on issue #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m… URL: https://github.com/apache/hadoop/pull/1311#issuecomment-523132564 Thanks @vivekratnavel for working on this. The changes look good to me overall with two issues: 1. The integration test failure testSecureOmInitFailures is related where the component name need to be passed into getKeyLocation(). 2. The key/cert location change also needs further changes for secure GRPC as they are currently calling into the getKeyLocation() without giving component name. When we move the DN keys under ".../dn/keys", the GRPC client/server (DNs) will not be able to find the keys under ".../keys".
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
