bharatviswa504 commented on a change in pull request #1263: HDDS-1927.
Consolidate add/remove Acl into OzoneAclUtil class. Contri…
URL: https://github.com/apache/hadoop/pull/1263#discussion_r315901670
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
##########
@@ -235,123 +231,22 @@ public FileEncryptionInfo getFileEncryptionInfo() {
return encInfo;
}
- public List<OzoneAclInfo> getAcls() {
+ public List<OzoneAcl> getAcls() {
Review comment:
> Good point. CheckAccess does the the byte array based protobuf acl to
BitSet based acl conversion each time, which is most of the work we do for
protobuf conversion from OzoneAclInfo to OzoneAcl. Consolidate this into
OzoneAcl class allows us to change the logic in a single place for optimization
in future.
Ya right. I think it should be fine I believe. (But still, we have little
advantage of not converting entire protobuf object. But I am fine with the
current way. :))
> Key creation usually needs to inherit the acls from prefix tree, where
efficient merge of supplied acls along with the acls from in-memory prefix
tree. It is currently not done properly tracked by HDDS-1913.
HDDS-1913 is for fixing OzoneBucket and RpcClient APIS for acl. Is there
another jira to fix the above issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
