jojochuang commented on a change in pull request #1313: HDFS-13118. SnapshotDiffReport should provide the INode type. URL: https://github.com/apache/hadoop/pull/1313#discussion_r315956729
########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotDiffListingInfo.java ########## @@ -32,6 +32,9 @@ import com.google.common.base.Preconditions; import org.apache.hadoop.util.ChunkedArrayList; +import static org.apache.hadoop.hdfs.protocol.SnapshotDiffReportListing.DiffReportListingEntry.INodeType.*; Review comment: let's not use wildcard import ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
