elek commented on a change in pull request #1255: HDDS-1935. Improve the visibility with Ozone Insight tool URL: https://github.com/apache/hadoop/pull/1255#discussion_r316023955
########## File path: hadoop-ozone/insight/src/main/java/org/apache/hadoop/ozone/insight/ConfigurationSubCommand.java ########## @@ -0,0 +1,70 @@ +package org.apache.hadoop.ozone.insight; + +import org.apache.hadoop.hdds.cli.HddsVersionProvider; +import org.apache.hadoop.hdds.conf.Config; +import org.apache.hadoop.hdds.conf.ConfigGroup; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; + +import picocli.CommandLine; + +import java.lang.reflect.Method; +import java.util.concurrent.Callable; + +/** + * Subcommand to show configuration values/documentation. + */ [email protected]( + name = "config", + description = "Show configuration for a specific subcomponents", + mixinStandardHelpOptions = true, + versionProvider = HddsVersionProvider.class) +public class ConfigurationSubCommand extends BaseInsightSubcommand + implements Callable<Void> { + + @CommandLine.Parameters(defaultValue = "") + private String selection; + + @Override + public Void call() throws Exception { + InsightPoint insight = + getInsight(getInsightCommand().createOzoneConfiguration(), selection); + System.out.println( + "Configuration for `" + selection + "` (" + insight.getDescription() + + ")"); + System.out.println(); + for (Class clazz : insight.getConfigurationClasses()) { + showConfig(clazz); + + } + return null; + } + + private void showConfig(Class clazz) { + OzoneConfiguration conf = new OzoneConfiguration(); + conf.addResource("http://localhost:9876/conf";); Review comment: 1. We can use any of the servers but SCM seems to be a safe choice as it should run all of the time 2. I modified it to use `getHost()` instead of the hard coded localhost name here... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
