bharatviswa504 commented on a change in pull request #670: HDDS-1347. In OM HA
getS3Secret call Should happen only leader OM.
URL: https://github.com/apache/hadoop/pull/670#discussion_r316390671
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -2683,6 +2683,14 @@ public void deleteS3Bucket(String s3BucketName) throws
IOException {
* {@inheritDoc}
*/
public S3SecretValue getS3Secret(String kerberosID) throws IOException{
+ UserGroupInformation user = ProtobufRpcEngine.Server.getRemoteUser();
+
+ // Check whether user name passed is matching with the current user or not.
Review comment:
This was based on some related review comments when original change for
getS3Secret is implemented.
So, I implemented it as part of this.
As without this, some other user can get secrets for other users's.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
