bshashikant commented on a change in pull request #1313: HDFS-13118.
SnapshotDiffReport should provide the INode type.
URL: https://github.com/apache/hadoop/pull/1313#discussion_r316506315
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotDiffListingInfo.java
##########
@@ -156,6 +163,17 @@ boolean addDirDiff(long dirId, byte[][] parent,
ChildrenDiff diff) {
return fullPath;
}
+ private static DiffReportListingEntry.INodeType fromINode(INode inode) {
Review comment:
can we also rename the routine to getInodeType()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
