xiaoyuyao commented on a change in pull request #1315: HDDS-1975. Implement
default acls for bucket/volume/key for OM HA code.
URL: https://github.com/apache/hadoop/pull/1315#discussion_r317270565
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
##########
@@ -351,28 +362,65 @@ protected OmKeyInfo createKeyInfo(@Nonnull KeyArgs
keyArgs,
.setDataSize(size)
.setReplicationType(type)
.setReplicationFactor(factor)
- .setFileEncryptionInfo(encInfo);
+ .setFileEncryptionInfo(encInfo)
+ .setAcls(getAclsForKey(keyArgs, omBucketInfo, prefixManager)).build();
+ }
+
+ private List< OzoneAcl > getAclsForKey(KeyArgs keyArgs,
Review comment:
Can we move this to some common helper util such as OzoneAclUtil to avoid
duplicate code in KeyManagerImpl#getAclsForKey?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
