adoroszlai commented on a change in pull request #1348: HDDS-2030. Generate simplifed reports by the dev-support/checks/*.sh scripts URL: https://github.com/apache/hadoop/pull/1348#discussion_r317943093
########## File path: hadoop-ozone/dev-support/checks/acceptance.sh ########## @@ -29,6 +29,7 @@ fi cd "$DIST_DIR/compose" || exit 1 ./test-all.sh +RES=$? cp results/* "$REPORT_DIR/" cp "$REPORT_DIR/log.html" "$REPORT_DIR/summary.html" -exit $? +return $RES Review comment: bash says: `can only 'return' from a function or sourced script` (exit code of `acceptance.sh` would be 1 if executed directly instead of sourcing it) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
