lokeshj1703 commented on a change in pull request #1318: HDDS-1753. Datanode
unable to find chunk while replication data using ratis.
URL: https://github.com/apache/hadoop/pull/1318#discussion_r317980266
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java
##########
@@ -143,6 +150,52 @@ public BackgroundTaskQueue getTasks() {
return queue;
}
+ public List<ContainerData> chooseContainerForBlockDeletion(int count,
+ ContainerDeletionChoosingPolicy deletionPolicy)
+ throws StorageContainerException {
+ Map<Long, ContainerData> containerDataMap =
+ ozoneContainer.getContainerSet().getContainerMap().entrySet().stream()
+ .filter(e -> isDeletionAllowed(e.getValue().getContainerData(),
+ deletionPolicy)).collect(Collectors
+ .toMap(Map.Entry::getKey, e -> e.getValue().getContainerData()));
+ return deletionPolicy
+ .chooseContainerForBlockDeletion(count, containerDataMap);
+ }
+
+ private boolean isDeletionAllowed(ContainerData containerData,
+ ContainerDeletionChoosingPolicy deletionPolicy) {
+ if (!deletionPolicy
+ .isValidContainerType(containerData.getContainerType())) {
+ return false;
+ } else if (!containerData.isClosed()) {
+ return false;
+ } else {
+ if (ozoneContainer.getWriteChannel() instanceof XceiverServerRatis) {
+ try {
+ XceiverServerRatis ratisServer =
+ (XceiverServerRatis) ozoneContainer.getWriteChannel();
+ long minReplicatedIndex =
ratisServer.getMinReplicatedIndex(PipelineID
+ .valueOf(UUID.fromString(containerData.getOriginPipelineId())));
Review comment:
If the pipeline does not exist, it should throw GroupMismatchException here.
We can check what exception is thrown once. In that case we need to return true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
