xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support
multiple excluded scopes when choosing datanodes in NetworkTopology
URL: https://github.com/apache/hadoop/pull/1194#discussion_r319607368
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetUtils.java
##########
@@ -71,35 +72,39 @@ public static int locationToDepth(String location) {
* Remove node from mutableExcludedNodes if it's covered by excludedScope.
* Please noted that mutableExcludedNodes content might be changed after the
* function call.
- * @return the new excludedScope
*/
- public static String removeDuplicate(NetworkTopology topology,
- Collection<Node> mutableExcludedNodes, String excludedScope,
+ public static void removeDuplicate(NetworkTopology topology,
+ Collection<Node> mutableExcludedNodes, List<String>
mutableExcludedScopes,
int ancestorGen) {
if (mutableExcludedNodes == null || mutableExcludedNodes.size() == 0 ||
Review comment:
NIT: We can use CollectionUtils.isEmpty() to simplify the code at 79/80.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
