hadoop-yetus commented on a change in pull request #1383: In YARN ui2
applications tab, If finishTime is 0, 'NA' should be displayed at this time,
indicating that the task is not finished yet
URL: https://github.com/apache/hadoop/pull/1383#discussion_r320045831
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/utils/converter.js
##########
@@ -83,7 +83,7 @@ export default {
return total * 1000;
},
timeStampToDate: function(timeStamp) {
- return convertTimestampWithTz(timeStamp, "YYYY/MM/DD HH:mm:ss");
+ return timeStamp == 0 ? "NA" : (0,
_yarnUiUtilsDateUtils.convertTimestampWithTz)(timeStamp, "YYYY/MM/DD HH:mm:ss");
Review comment:
jshint:24:W116:Expected '===' and instead saw '=='.
jshint:40:W117:'_yarnUiUtilsDateUtils' is not defined.
jshint:85:W067:Bad invocation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
