steveloughran commented on a change in pull request #1394: Hadoop-16438 ADLS
Gen1 OpenSSL config control
URL: https://github.com/apache/hadoop/pull/1394#discussion_r320265898
##########
File path:
hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/live/TestAdlSdkConfiguration.java
##########
@@ -74,4 +75,67 @@ public void testDefaultTimeout() throws IOException {
// The default value may vary by SDK, so that value is not tested here.
}
+
+ @Test
+ public void testSSLChannelMode() throws IOException {
Review comment:
this test goes through all the different configurations and then retries the
same action through copy-pase (==maintenance cost). Either pull the common code
into a method called repeatedly, or use parameterized junit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
