swagle commented on a change in pull request #1366: HDDS-1577. Add default 
pipeline placement policy implementation.
URL: https://github.com/apache/hadoop/pull/1366#discussion_r320408049
 
 

 ##########
 File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/states/Node2ObjectsMap.java
 ##########
 @@ -83,7 +83,7 @@ public void insertNewDatanode(UUID datanodeID, Set<T> 
containerIDs)
    *
    * @param datanodeID - Datanode ID.
    */
-  void removeDatanode(UUID datanodeID) {
+  public void removeDatanode(UUID datanodeID) {
 
 Review comment:
   Should annotate these methods as @VisibleForTesting

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to