xiaoyuyao commented on a change in pull request #1361: HDDS-1553. Add metrics in rack aware container placement policy. URL: https://github.com/apache/hadoop/pull/1361#discussion_r320487548
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMPlacementMetrics.java ########## @@ -0,0 +1,107 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdds.scm.container.placement.algorithms; + +import com.google.common.annotations.VisibleForTesting; +import org.apache.hadoop.metrics2.MetricsCollector; +import org.apache.hadoop.metrics2.MetricsInfo; +import org.apache.hadoop.metrics2.MetricsSource; +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.Interns; +import org.apache.hadoop.metrics2.lib.MetricsRegistry; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; + +/** + * This class is for maintaining Topology aware placement statistics. + */ +@Metrics(about="SCM Placement Metrics", context = "ozone") +public class SCMPlacementMetrics implements MetricsSource { + public static final String SOURCE_NAME = + SCMPlacementMetrics.class.getSimpleName(); + private static final MetricsInfo RECORD_INFO = Interns.info(SOURCE_NAME, + "SCM Placement Metrics"); + private static MetricsRegistry registry; + + // total datanode allocation request count + @Metric private MutableCounterLong datanodeRequestCount; + // datanode allocation tried count, including success, fallback and failed + @Metric private MutableCounterLong datanodeAllocationTryCount; + // datanode successful allocation count + @Metric private MutableCounterLong datanodeAllocationSuccessCount; + // datanode allocated with some allocation constrains compromised + @Metric private MutableCounterLong datanodeAllocationCompromiseCount; + + public SCMPlacementMetrics() { + } + + public static SCMPlacementMetrics create() { Review comment: can we add a helper to unregister the metrics? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
