ChenSammi commented on a change in pull request #1366: HDDS-1577. Add default
pipeline placement policy implementation.
URL: https://github.com/apache/hadoop/pull/1366#discussion_r320552958
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeManager.java
##########
@@ -129,6 +138,18 @@
*/
void removePipeline(Pipeline pipeline);
+ /**
+ * Get the entire Node2PipelineMap.
+ * @return Node2PipelineMap
+ */
+ Node2PipelineMap getNode2PipelineMap();
+
+ /**
+ * Set the Node2PipelineMap.
+ * @param node2PipelineMap Node2PipelineMap
+ */
+ void setNode2PipelineMap(Node2PipelineMap node2PipelineMap);
Review comment:
I would suggest to remove this function from interface definition since it's
only used in test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
