steveloughran commented on a change in pull request #1359:
HADOOP-16430.S3AFilesystem.delete to incrementally update s3guard with deletions
URL: https://github.com/apache/hadoop/pull/1359#discussion_r321247382
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextURIBase.java
##########
@@ -418,7 +419,7 @@ public void testDeleteDirectory() throws IOException {
@Test
public void testDeleteNonExistingDirectory() throws IOException {
- String testDirName = "testFile";
+ String testDirName = "testDeleteNonExistingDirectory";
Review comment:
junit test method's rule does this, and when you parameterize it you get
the extended name including parameters, so you automatically get isolation.
But, you'd better make sure all those params form valid paths, and not have,
say : or / in them. I didn't do the fixup here as this was a emergency fixup,
not rework.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
