[ 
https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924193#comment-16924193
 ] 

Vinayakumar B commented on HADOOP-13363:
----------------------------------------

It took > 2hrs to come to stage of verifying the patch for compilation.

 

Apparently, compilation failed at root, because No shading of protobuf happened 
without "mvn install'
{noformat}
15:49:34  
============================================================================
15:49:34  
============================================================================
15:49:34                           trunk compilation: patch
15:49:34  
============================================================================
15:49:34  
============================================================================
15:49:34  
15:49:34  
15:49:41  cd 
/home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1408/src
15:49:41  /usr/bin/mvn --batch-mode -Ptest-patch -DskipTests -Pnative 
-Drequire.fuse -Drequire.openssl -Drequire.snappy -Drequire.valgrind 
-Drequire.test.libhadoop -Pyarn-ui clean test-compile -DskipTests=true > 
/home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1408/out/patch-compile-root.txt
 2>&1
15:50:21  Elapsed:   0m 46s
15:50:21  
15:50:21  root in the patch failed.{noformat}
shade plugin cannot run in compile phase. It can only run in "package" phase.

So shaded classes are not available for compilation. 

 

Added one more commit to PR to exclude "hadoop-build-shaded-dependency" from 
build, so that always shaded artifacts are referred during compile goal 
execution.

 

> Upgrade protobuf from 2.5.0 to something newer
> ----------------------------------------------
>
>                 Key: HADOOP-13363
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13363
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0-alpha1, 3.0.0-alpha2
>            Reporter: Allen Wittenauer
>            Assignee: Vinayakumar B
>            Priority: Major
>              Labels: security
>         Attachments: HADOOP-13363.001.patch, HADOOP-13363.002.patch, 
> HADOOP-13363.003.patch, HADOOP-13363.004.patch, HADOOP-13363.005.patch
>
>
> Standard protobuf 2.5.0 does not work properly on many platforms.  (See, for 
> example, https://gist.github.com/BennettSmith/7111094 ).  In order for us to 
> avoid crazy work arounds in the build environment and the fact that 2.5.0 is 
> starting to slowly disappear as a standard install-able package for even 
> Linux/x86, we need to either upgrade or self bundle or something else.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to