hadoop-yetus commented on a change in pull request #1411: HDDS-2098 : Ozone 
shell command prints out ERROR when the log4j file …
URL: https://github.com/apache/hadoop/pull/1411#discussion_r321889337
 
 

 ##########
 File path: hadoop-ozone/common/src/main/bin/ozone
 ##########
 @@ -69,6 +69,12 @@ function ozonecmd_case
   subcmd=$1
   shift
 
+  ozone_default_log4j="${HADOOP_CONF_DIR}/log4j.properties"
+  ozone_shell_log4j="${HADOOP_CONF_DIR}/ozone-shell-log4j.properties"
+  if [ ! -f ${ozone_shell_log4j} ]; then
 
 Review comment:
   shellcheck:13: note: Double quote to prevent globbing and word splitting. 
[SC2086]
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to