bgaborg commented on a change in pull request #1407: HADOOP-16490. Improve
S3Guard handling of FNFEs in copy
URL: https://github.com/apache/hadoop/pull/1407#discussion_r322288627
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ARemoteFileChanged.java
##########
@@ -723,6 +729,86 @@ public void testRenameEventuallyConsistentDirectory()
throws Throwable {
fs.rename(sourcedir, destdir);
}
+ /**
+ * Tests doing a rename() on a file which is eventually visible.
+ */
+ @Test
+ public void testRenameEventuallyVisibleFile() throws Throwable {
+ requireS3Guard();
+ AmazonS3 s3ClientSpy = spyOnFilesystem();
+ Path basedir = path();
+ Path sourcedir = new Path(basedir, "sourcedir");
+ fs.mkdirs(sourcedir);
+ Path destdir = new Path(basedir, "destdir");
+ String inconsistent = "inconsistent";
Review comment:
you could add this as a constant to the whole test, you are using it more
than once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
