bgaborg commented on issue #1208: HADOOP-16423. S3Guard fsck: Check metadata consistency between S3 and metadatastore (log) URL: https://github.com/apache/hadoop/pull/1208#issuecomment-529676557 Thank you very much for the review @steveloughran. It's really thorough, complete. To be honest the code was really rough in the edges - I wanted another round before the final review just to have the idea right, because if we agree on the design then I can remove things like a system.out from here and there. So usually I just leave these things there as long as the bigger concept is not settled. But usually, this is the way how these things will creep into the code and stay there. Like this time: I forgot to return to my PR and do my cleanup.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
