mukul1987 commented on a change in pull request #1420: HDDS-2032. Ozone client
should retry writes in case of any ratis/stateMachine exceptions.
URL: https://github.com/apache/hadoop/pull/1420#discussion_r322872820
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java
##########
@@ -290,11 +288,12 @@ private void handleException(BlockOutputStreamEntry
streamEntry,
if (!failedServers.isEmpty()) {
excludeList.addDatanodes(failedServers);
}
- if (closedContainerException) {
+
+ // if the container needs to be excluded , add the container to the
+ // exclusion list , otherwise add the pipeline to the exclusion list
+ if (containerExclusionException) {
excludeList.addConatinerId(ContainerID.valueof(containerId));
- } else if (retryFailure || t instanceof TimeoutException
- || t instanceof GroupMismatchException
- || t instanceof NotReplicatedException) {
+ } else {
Review comment:
So apart from SCE, all exceptions are expected to be related to the pipeline
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
